Open
Conversation
marler8997
force-pushed
the
headerChecks
branch
3 times, most recently
from
7576257 to
33d14a8
Compare
marler8997
force-pushed
the
headerChecks
branch
from
33d14a8 to
fed7d52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does speed up the build but I'm actually not sure it's best yet. It will speed up the first build but, it also adds time to subsequent builds, it's not much time (maybe 10ms or so) but I'd like to explore better solutions that don't add 10ms to every build, where we can query the filesystem only when python needs to be rebuilt.